Skip to content

Fix nested Antelope parameter history serialization - #922

Merged
wangyinz merged 1 commit into
masterfrom
codex/issue-781-history-pf
Aug 23, 2026
Merged

wangyinz merged 1 commit into
masterfrom
codex/issue-781-history-pf

Conversation

@wangyinz

@wangyinz wangyinz commented Aug 12, 2026 •

Copy link
Copy Markdown
Member

Summary

  • Recursively preserve simple values, Tbl values, and nested Arr branches in Antelope parameter history.
  • Make pfbranch_to_dict return only the requested branch.
  • Preserve OrderedDict results, native value types, missing-branch errors, and source-object immutability.

Validation

  • Focused and adjacent history tests: 6 passed
  • Black, Python byte compilation, and git diff --check

Closes #781

@codecov

codecov Bot commented Aug 12, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.90%. Comparing base (eed4fcf) to head (dcc1867).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #922      +/-   ##
==========================================
+ Coverage   72.81%   72.90%   +0.08%     
==========================================
  Files         182      182              
  Lines       36139    36127      -12     
  Branches     2532     2532              
==========================================
+ Hits        26314    26337      +23     
+ Misses       8919     8885      -34     
+ Partials      906      905       -1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@wangyinz
wangyinz marked this pull request as draft August 14, 2026 05:58
@wangyinz
wangyinz marked this pull request as ready for review August 14, 2026 15:44
@wangyinz
wangyinz force-pushed the codex/issue-781-history-pf branch from daf555d to dcc1867 Compare August 23, 2026 17:07
@wangyinz

Copy link
Copy Markdown
Member Author

Final audit complete: the conversion is limited to complete AntelopePf value preservation, requested-branch isolation, native type retention, and source immutability. Missing branches keep the established MsPASSError behavior. The rebased focused and adjacent suites pass 6 tests; no further human decision is required.

@wangyinz
wangyinz merged commit 9704f48 into master Aug 23, 2026
18 checks passed
@wangyinz
wangyinz deleted the codex/issue-781-history-pf branch August 23, 2026 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[P1][History] Preserve nested AntelopePf branches and Tbl values

1 participant